Handle Postgres 17 checkpointer stats #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Sandquist <[email protected]>
tsndqst
force-pushed
the
checkpointer_stats
branch
from
83c8346 to
d67ace5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PostgreSQL 17 the checkpointer got its own view so the stats have different metric names in Prometheus. I tested this change on both Postgres 17 clusters as well as a Postgres 16 cluster.
New metrics:
cnpg_pg_stat_checkpointer_checkpoints_reqcnpg_pg_stat_checkpointer_checkpoints_timedcnpg_pg_stat_checkpointer_write_timecnpg_pg_stat_checkpointer_sync_time